Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox][asan] add address sanitizer support for syncd #10266

Merged
merged 3 commits into from
Apr 14, 2022
Merged

[Mellanox][asan] add address sanitizer support for syncd #10266

merged 3 commits into from
Apr 14, 2022

Conversation

Yakiv-Huryk
Copy link
Contributor

Why I did it

To support address sanitizer for Mellanox syncd

How I did it

  • /var/log/asan is mapped for syncd container (the same as for swss)
  • container stop() has a timeout (60s) for syncd (the same as for swss)
    This is so libasan has enough time to generate a report.
  • added ASAN's log path to Mellanox syncd supervisord.conf
  • added "asan: yes" to sonic_version.yml

How to verify it

  1. Added artificial memory leaks
  2. Compiled with ENABLE_ASAN=y
  3. Installed the image on DUT
  4. Rebooted the DUT
  5. Verified that /var/log/asan/syncd-asan.log contains the leaks

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ghost
Copy link

ghost commented Mar 17, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

yxieca
yxieca previously approved these changes Mar 24, 2022
View reviewed changes
@yxieca
Copy link
Contributor

yxieca commented Mar 24, 2022

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@yxieca
Copy link
Contributor

yxieca commented Mar 24, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp Azure.sonic-buildimage

@azure-pipelines
Copy link

Command 'Azure.sonic-buildimage' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@Yakiv-Huryk
[Mellanox][asan] add address sanitizer support for syncd
ae40047 
If ENABLE_ASAN is on:
* /var/log/asan is mapped for syncd
* container stop() has a timeout (60s) for syncd.
This is so libasan has enough time to generate a report.

Signed-off-by: Yakiv Huryk <[email protected]>
@Yakiv-Huryk
[asan] add asan flag to sonic_version.yml
0d9fc06 
Signed-off-by: Yakiv Huryk <[email protected]>
@Yakiv-Huryk
Copy link
Contributor Author

@yxieca sorry, I had to rebase since the diff to master was too big, and merge produced a lot of commits in this pr.

@liat-grozovik
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@yxieca kindly reminder to signoff the PR

@yxieca yxieca merged commit d9117d9 into sonic-net:master Apr 14, 2022
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
@yxieca
Merged PR 6004325: Manual merge github master to internal
19c4542 
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

@oleksandrivantsiv oleksandrivantsiv oleksandrivantsiv approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

@prsunny prsunny Awaiting requested review from prsunny

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yakiv-Huryk @yxieca @liat-grozovik @oleksandrivantsiv